Skip to content

Chemical Softening Pending Issues #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 29, 2025
Merged

Chemical Softening Pending Issues #130

merged 12 commits into from
Mar 29, 2025

Conversation

MuktaHardikar
Copy link
Collaborator

Added equations to calculate the alkalinity concentration in the outlet based on the softening procedure.

  1. For single-stage-lime and excess-lime: Examples in the book were used to build equations (Crittenden, J. C., & Montgomery Watson Harza (Firm). (2012). Water treatment principles and design. Hoboken, N.J: J.Wiley.)
  2. For single-stage-lime-soda and excess-lime-soda, methods provided by NMSU were used. Need to be verified.

@kurbansitterley kurbansitterley mentioned this pull request Oct 10, 2024
Open
8 tasks
@adam-a-a adam-a-a added Priority:High Normal Priority Issue or PR Priority:Normal Normal Priority Issue or PR and removed Priority:Normal Normal Priority Issue or PR Priority:High Normal Priority Issue or PR labels Dec 9, 2024
@kurbansitterley kurbansitterley marked this pull request as ready for review March 28, 2025 16:34
@kurbansitterley kurbansitterley self-requested a review March 28, 2025 16:34
kurbansitterley
kurbansitterley approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@kurbansitterley kurbansitterley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we talked about this quite a bit.

src/watertap_contrib/reflo/unit_models/chemical_softening.py Outdated
@@ -1028,6 +1027,109 @@ def eq_mass_balance_mg(b):
to_units=pyunits.kg / pyunits.s,
)

# TODO:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MuktaHardikar is this still a TODO or is this completed with the code below?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly yes. Need to remove the TODO. The comments would be good to help track the source.

zacharybinger
zacharybinger approved these changes Mar 28, 2025
View reviewed changes
Copy link
Collaborator

@zacharybinger zacharybinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kurbansitterley kurbansitterley merged commit 283ee52 into watertap-org:main Mar 29, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharybinger zacharybinger zacharybinger approved these changes

@kurbansitterley kurbansitterley kurbansitterley approved these changes

Assignees

@MuktaHardikar MuktaHardikar

Labels
Priority:Normal Normal Priority Issue or PR treatment model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MuktaHardikar @zacharybinger @kurbansitterley @adam-a-a